New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Button to token system #1228

Draft

Oksamies wants to merge 1 commit into master from 10-11-refactor_button_to_token_system

Contributor

Oksamies commented Oct 11, 2024

No description provided.

Contributor Author

Oksamies commented Oct 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Refactor Button to token system #1228 👈
/communities second QA fixes #1226
Fix issues brought up in QA of PR #1206 #1214 : 1 other dependent PR (#1215 )
Fix faulty session issues and login styles #1207
Introduce new systems, components and rewrite /communities #1206
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Oksamies and the rest of your teammates on Graphite

Oksamies mentioned this pull request

/communities second QA fixes #1226

Merged

github-advanced-security bot found potential problems

View reviewed changes

packages/cyberstorm/src/newComponents/Button/Button.tsx

+                disabled?: boolean;
+              }
+              interface ButtonProps extends Omit<ActionableButtonProps, "primitiveType" | "csVariant">, Modifiers {

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ·extends·Omit<ActionableButtonProps,·"primitiveType"·|·"csVariant">, with ⏎··extends·Omit<ActionableButtonProps,·"primitiveType"·|·"csVariant">,⏎···

packages/cyberstorm/src/newComponents/Button/Button.tsx

                 csSize?: "xs" | "s" | "m" | "l";
               }
               interface IconButtonProps
                 extends Omit<
                   ActionableButtonProps,
                   "primitiveType" | "csVariant" | "csSize" | "children"
-                > {
+                >, Modifiers {

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace >, with ··>,⏎···

packages/cyberstorm/src/newComponents/Button/Button.tsx

+                  m: buttonStyles["button--size-m"],
+                  l: buttonStyles["button--size-l"],
+                }[scheme];
+              };

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Insert ⏎

Oksamies force-pushed the 10-11-refactor_button_to_token_system branch from 60d4195 to 71b2bfa Compare

October 11, 2024 12:43

github-advanced-security bot found potential problems

View reviewed changes

packages/cyberstorm/src/newComponents/Button/Button.tsx

@@ @@ -46,12 +51,11 @@ @@
               export const Button = React.forwardRef<HTMLButtonElement, ButtonComponentProps>(
                 (props: ButtonComponentProps, forwardedRef) => {
-                  const { rootClasses, csTextStyles, icon, ...forwardedProps } = props;
+                  const { rootClasses, csTextStyles, icon, dimmed, subtle, disabled,  ...forwardedProps } = props;

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ·rootClasses,·csTextStyles,·icon,·dimmed,·subtle,·disabled,··...forwardedProps with ⏎······rootClasses,⏎······csTextStyles,⏎······icon,⏎······dimmed,⏎······subtle,⏎······disabled,⏎······...forwardedProps⏎···

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

Comment on lines +17 to +18

		interface CyberstormLinkProps extends ActionableCyberstormLinkProps, Modifiers {}

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ·extends·ActionableCyberstormLinkProps,·Modifiers·{}⏎ with ⏎··extends·ActionableCyberstormLinkProps,⏎····Modifiers·{}

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

                     csSize = "m",
                     csTextStyles,
+                    dimmed,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Delete ··

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

                     csSize = "m",
                     csTextStyles,
+                    dimmed,
+                    subtle,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ······ with ····

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

                     csSize = "m",
                     csTextStyles,
+                    dimmed,
+                    subtle,
+                    disabled,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Delete ··

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

-                        styles.button,
+                        buttonStyles.button,
+                        getSize(csSize),
+                        getVariant(csVariant),

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Delete ··

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

+                        buttonStyles.button,
+                        getSize(csSize),
+                        getVariant(csVariant),
+                        dimmed ? buttonStyles["button--dimmed"] : null,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Delete ··

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

+                        getSize(csSize),
+                        getVariant(csVariant),
+                        dimmed ? buttonStyles["button--dimmed"] : null,
+                        subtle ? buttonStyles["button--subtle"] : null,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace ·········· with ········

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

+                        getVariant(csVariant),
+                        dimmed ? buttonStyles["button--dimmed"] : null,
+                        subtle ? buttonStyles["button--subtle"] : null,
+                        disabled ? buttonStyles["button--disabled"] : null,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Delete ··

packages/cyberstorm/src/newComponents/Link/LinkButton/LinkButton.tsx

+                  m: buttonStyles["button--size-m"],
+                  l: buttonStyles["button--size-l"],
+                }[scheme];
+              };

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Insert ⏎

Oksamies force-pushed the 10-11-refactor_button_to_token_system branch 2 times, most recently from ab94adc to c00d254 Compare

October 15, 2024 10:11


          Refactor Button to token system

bc0dbf8

Oksamies force-pushed the 10-11-refactor_button_to_token_system branch from c00d254 to bc0dbf8 Compare

October 15, 2024 11:06

Base automatically changed from 10-08-_communities_second_qa_fixes to 09-25-fix_issues_brought_up_in_qa_of_pr_1206

October 15, 2024 17:13

Base automatically changed from 09-25-fix_issues_brought_up_in_qa_of_pr_1206 to 09-19-Fix_faulty_session_issues_and_login_styles

October 15, 2024 17:14

Base automatically changed from 09-19-Fix_faulty_session_issues_and_login_styles to new-systems-and-communites-rewrite-v2

October 15, 2024 17:14

Base automatically changed from new-systems-and-communites-rewrite-v2 to master

October 15, 2024 18:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet